-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add Windows ARM64
to flaky-tests list
#54693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Sep 1, 2024
targos
reviewed
Sep 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sgtm but I think the other entry should specify x64, like for macOS
RedYetiDev
added
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
windows
Issues and PRs related to the Windows platform.
arm
Issues and PRs related to the ARM platform.
labels
Sep 1, 2024
wojtekmaj
reviewed
Sep 1, 2024
targos
approved these changes
Sep 2, 2024
mcollina
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lpinca
approved these changes
Sep 6, 2024
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 6, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 6, 2024
Landed in c046c9b |
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Sep 10, 2024
PR-URL: nodejs#54693 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54693 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arm
Issues and PRs related to the ARM platform.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
meta
Issues and PRs related to the general management of the project.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #54645, it is possible for issues to only affect this specific platform, so this PR adds it to selection menu when reporting a flaky test.